-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mam/iq fin transformations #3191
Conversation
small_tests_23 / small_tests / ddf25a9 internal_mnesia / internal_mnesia / ddf25a9 small_tests_24 / small_tests / ddf25a9 small_tests_22 / small_tests / ddf25a9 dynamic_domains / pgsql_mnesia / ddf25a9 ldap_mnesia_22 / ldap_mnesia / ddf25a9 ldap_mnesia_23 / ldap_mnesia / ddf25a9 ldap_mnesia_24 / ldap_mnesia / ddf25a9 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / ddf25a9 pgsql_mnesia_24 / pgsql_mnesia / ddf25a9 mssql_mnesia_24 / odbc_mssql_mnesia / ddf25a9 pgsql_mnesia_22 / pgsql_mnesia / ddf25a9 elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / ddf25a9 mssql_mnesia / odbc_mssql_mnesia / ddf25a9 mysql_redis / mysql_redis / ddf25a9 pgsql_mnesia / pgsql_mnesia / ddf25a9 mysql_redis_24 / mysql_redis / ddf25a9 pep_SUITE:pep_tests:unsubscribe_after_presence_unsubscription{error,
{{badmatch,
[{xmlel,<<"message">>,
[{<<"from">>,
<<"alice_unsubscribe_after_presence_unsubscription_82.25958@localhost">>},
{<<"to">>,
<<"bob_unsubscribe_after_presence_unsubscription_82.25958@localhost/res1">>},
{<<"type">>,<<"headline">>}],
[{xmlel,<<"event">>,
[{<<"xmlns">>,
<<"http://jabber.org/protocol/pubsub#event">>}],
[{xmlel,<<"items">>,
[{<<"node">>,<<"Rb3IeYVv4701XBNfJoMZbA==">>}],
[{xmlel,<<"item">>,
[{<<"id">>,<<"salmon">>}],
[{xmlel,<<"entry">>,
[{<<"xmlns">>,
<<"http://www.w3.org/2005/Atom">>}],
[]}]}]}]},
{xmlel,<<"headers">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/shim">>}],
[]}]}]},
[{pep_SUITE,'-unsubscribe_after_presence_unsubscription/1-fun-0-',2,
[{file,"/home/circleci/app/big_tests/tests/pep_SUITE.erl"},
{line,382}]},
{escalus_story,story,4,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
{line,72}]},
{test_server,ts_tc,3,[{file,"test_server.erl"},{line,1783}]},
{test_server,run_test_case_eval1,6,
[{file,"test_server.erl"},{line,1292}]},
{test_server,run_test_case_eval,9,
[{file,"test_server.erl"},{line,1224}]}]}} riak_mnesia_24 / riak_mnesia / ddf25a9 riak_mnesia / riak_mnesia / ddf25a9 |
Codecov Report
@@ Coverage Diff @@
## master #3191 +/- ##
=======================================
Coverage 80.32% 80.33%
=======================================
Files 397 397
Lines 32430 32436 +6
=======================================
+ Hits 26051 26057 +6
Misses 6379 6379
Continue to review full report at Codecov.
|
small_tests_23 / small_tests / 2a30417 internal_mnesia / internal_mnesia / 2a30417 small_tests_24 / small_tests / 2a30417 dynamic_domains / pgsql_mnesia / 2a30417 small_tests_22 / small_tests / 2a30417 ldap_mnesia_24 / ldap_mnesia / 2a30417 ldap_mnesia_22 / ldap_mnesia / 2a30417 mod_global_distrib_SUITE:multi_connection:test_muc_conversation_history{error,
{{assertion_failed,assert,is_stanza_from,
[<<"[email protected]/alicE_test_muc_conversation_history_22.672877">>],
{xmlel,<<"presence">>,
[{<<"from">>,
<<"[email protected]/eve_test_muc_conversation_history_22.724182">>},
{<<"to">>,
<<"eve_test_muc_conversation_history_22.724182@localhost/res1">>},
{<<"type">>,<<"error">>},
{<<"xml:lang">>,<<"en">>}],
[{xmlel,<<"x">>,
[{<<"xmlns">>,<<"http://jabber.org/protocol/muc">>}],
[]},
{xmlel,<<"error">>,
[{<<"code">>,<<"503">>},{<<"type">>,<<"cancel">>}],
[{xmlel,<<"service-unavailable">>,
[{<<"xmlns">>,
<<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
[]}]}]},
"<presence from='[email protected]/eve_test_muc_conversation_history_22.724182' to='eve_test_muc_conversation_history_22.724182@localhost/res1' type='error' xml:lang='en'><x xmlns='http://jabber.org/protocol/muc'/><error code='503' type='cancel'><service-unavailable xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/></error></presence>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{mod_global_distrib_SUITE,wait_for_muc_presence,3,
[{file,
"/h... pgsql_mnesia_24 / pgsql_mnesia / 2a30417 elasticsearch_and_cassandra_24 / elasticsearch_and_cassandra_mnesia / 2a30417 ldap_mnesia_23 / ldap_mnesia / 2a30417 pgsql_mnesia / pgsql_mnesia / 2a30417 elasticsearch_and_cassandra / elasticsearch_and_cassandra_mnesia / 2a30417 pgsql_mnesia_22 / pgsql_mnesia / 2a30417 mysql_redis_24 / mysql_redis / 2a30417 mssql_mnesia / odbc_mssql_mnesia / 2a30417 mssql_mnesia_24 / odbc_mssql_mnesia / 2a30417 mysql_redis / mysql_redis / 2a30417 riak_mnesia_24 / riak_mnesia / 2a30417 riak_mnesia / riak_mnesia / 2a30417 jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_97.770221@localhost/res1">>},
{<<"id">>,<<"5f979736-6822-4818-93f6-a444919c5faf">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"a8b168e7-1e9c-4857-9d8c-4016c5c8f43d">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_97.770221@localhost/res1' id='5f979736-6822-4818-93f6-a444919c5faf' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='a8b168e7-1e9c-4857-9d8c-4016c5c8f43d'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,393}]},
{jingle_SUITE,
'-res... jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_8.150941@localhost/res1">>},
{<<"id">>,<<"5aff08e2-474f-43d3-a805-a24a0b94ba23">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"ad0f2812-9db7-495d-89c0-41ac4a7a888e">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_8.150941@localhost/res1' id='5aff08e2-474f-43d3-a805-a24a0b94ba23' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='ad0f2812-9db7-495d-89c0-41ac4a7a888e'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,393}]},
{jingle_SUITE,
'-resp_... jingle_SUITE:all:resp_4xx_from_sip_proxy_results_in_session_terminate{error,
{{assertion_failed,assert,is_iq_result,
{xmlel,<<"iq">>,
[{<<"from">>,<<"error.480@localhost">>},
{<<"to">>,
<<"alice_resp_4xx_from_sip_proxy_results_in_session_terminate_19.87265@localhost/res1">>},
{<<"id">>,<<"8dea62b3-1cc1-425a-8beb-b178ee4a6391">>},
{<<"type">>,<<"set">>}],
[{xmlel,<<"jingle">>,
[{<<"xmlns">>,<<"urn:xmpp:jingle:1">>},
{<<"action">>,<<"session-terminate">>},
{<<"sid">>,<<"e899eb5f-c7c1-4d34-96ad-9edcb615e13a">>}],
[{xmlel,<<"reason">>,[],
[{xmlel,<<"general-error">>,[],[]},
{xmlel,<<"sip-error">>,
[{<<"code">>,<<"480">>}],
[{xmlcdata,<<"Temporarily Unavailable">>}]}]}]}]},
"<iq from='error.480@localhost' to='alice_resp_4xx_from_sip_proxy_results_in_session_terminate_19.87265@localhost/res1' id='8dea62b3-1cc1-425a-8beb-b178ee4a6391' type='set'><jingle xmlns='urn:xmpp:jingle:1' action='session-terminate' sid='e899eb5f-c7c1-4d34-96ad-9edcb615e13a'><reason><general-error/><sip-error code='480'>Temporarily Unavailable</sip-error></reason></jingle></iq>"},
[{escalus_new_assert,assert_true,2,
[{file,
"/home/circleci/app/big_tests/_build/default/lib/escalus/src/escalus_new_assert.erl"},
{line,84}]},
{jingle_SUITE,send_initiate_and_wait_for_first_iq_set,2,
[{file,"/home/circleci/app/big_tests/tests/jingle_SUITE.erl"},
{line,393}]},
{jingle_SUITE,
'-resp_... riak_mnesia / riak_mnesia / 2a30417 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only for notes: need create s separate PR for describe new config option extra_fin_element
and similar like extra_params_module
etc. in documentation of MIM.
Sometimes it can be useful to be able to add information to a mam query, that doesn't belong to any specific message but to all of them. So being able to add subelements to the iq-fin element will solve the extensibility issue.